Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix js script dependency error #278

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Fix js script dependency error #278

merged 1 commit into from
Oct 19, 2023

Conversation

Utsav-Ladani
Copy link
Contributor

Fix js script dependency error

Changes

  • Add a check to enqueue a script only when the rtMedia plugin is activated.
  • class_exists( 'RTMedia' ) is used to check this.
  • This script is making changes to rtMedia UI components. So it is not required when rtMedia is deactivated/not installed.

@Utsav-Ladani
fix(app): Add condition to enqueue script from transcoder
a6d3576 
Enqueue script only if rtMedia class is exists. This script add some UI changes to rtMedia component, when it is used with transcoder.
vishalkakadiya
vishalkakadiya approved these changes Oct 19, 2023
View reviewed changes
Copy link

@vishalkakadiya vishalkakadiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Utsav-Ladani Utsav-Ladani merged commit 5663304 into develop Oct 19, 2023
3 of 4 checks passed
@Utsav-Ladani Utsav-Ladani deleted the fix/rtMedia-js-dependency branch October 19, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishalkakadiya vishalkakadiya vishalkakadiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Utsav-Ladani @vishalkakadiya